Contributing to the Marten project
Marten is a big project that will keep evolving over time. If you want to, there are many ways to get involved!
First things first...
The Marten project adheres to the Contributor Covenant Code of Conduct. Everyone contributing to the Marten project is expected to follow this code.
Reporting issues
You should use the project's issue tracker that is hosted on GitHub if you've found a bug or if you want to propose a new feature.
About bug reports
If you've found a bug related to the Marten web framework that is not a security issue, then you should (i) search the existing issues to verify that it hasn't been reported yet and (ii) create a new issue if that's not the case. Don't forget to include as many details as possible in your tickets: an explanatory description of the issue at hand and how to reproduce it, snippets and/or tracebacks if this is appropriate, etc.
About security issues
If you've found a security issue please do not open a GitHub issue. Instead, send an email to [email protected]. We'll then investigate together to resolve the problem so we can make an announcement about a solution along with the vulnerability.
Contributing code
The preferred way to contribute to the Marten framework is to submit pull requests to the project's GitHub repository. If you don't know where to start and would like to start contributing code to the Marten framework, you can have a look at the Good first issues.
Below are provided some general tips regarding contributing code: development environments, running tests, etc.
Development environment
First, you should fork the Marten git repository. Then you can get a local copy of the project using the following command:
git clone [email protected]:<username>/marten.git
Once this is done you should change into the marten repository and install the framework dependencies by running the following command:
make
This will install a bunch of Crystal shards and some Node.js dependencies (which are required to work on the Docusaurus-powered documentation).
Coding style
Overall, Marten tries to comply with Crystal's style guide and you should ensure that your changes comply with it as well if you are contributing code to the project.
In addition to that, Marten's codebase is checked using ameba and via the standard crystal tool format command. Every pull request opened on Marten's GitHub repository will be checked using these tools automatically. If needed, you can verify that these checks are passing locally by running the following commands:
make qa # Run both ameba and the Crystal formatting checks
make lint # Run ameba checks only
make format_checks # Run Crystal formatting checks only
Additionally, you can also apply Crystal's default formatting to the codebase by running:
make format
Tests
You should not submit pull requests without providing tests. Marten uses the standard spec module and comes with an extensive spec suite.
Specs must be defined in the spec folder, at the root of the project's repository. You can run the whole spec suite by using the following command (which is equivalent to running crystal spec):
make tests
By default, specs will be executed using an in-memory SQLite database. If you wish to, you can configure additional databases by updating the .spec.env.json file that should've been automatically generated by the make command earlier (cf. Development environment). This file defines a bunch of "environment" setting values that are automatically leveraged to configure the test project that is used when running specs. It looks something like this:
{
"MYSQL_DEFAULT_DB_NAME": "example",
"MYSQL_OTHER_DB_NAME": "other_example",
"MYSQL_DB_USER": "example",
"MYSQL_DB_PASSWORD": "",
"MYSQL_DB_HOST": "",
"POSTGRESQL_DEFAULT_DB_NAME": "example",
"POSTGRESQL_OTHER_DB_NAME": "other_example",
"POSTGRESQL_DB_USER": "example",
"POSTGRESQL_DB_PASSWORD": "",
"POSTGRESQL_DB_HOST": ""
}
As you can see, you have to specify two databases for each database backend (MySQL and PostgreSQL). This is mandatory because Marten's specs are also testing cases where multiple databases are configured and used simultaneously for the same project.
Specs are always executed using a single database backend. As mentioned previously this database backend is the SQLite one by default, but you can specify the one to use when running specs by setting the MARTEN_SPEC_DB_CONNECTION environment variable. For example:
MARTEN_SPEC_DB_CONNECTION=mysql make tests # Will run specs using the MySQL DB backend
MARTEN_SPEC_DB_CONNECTION=postgresql make tests # Will run specs using the PostgreSQL DB backend
Documentation
Marten's documentation is written using Markdown. It is powered by Docusaurus and lives under the docs folder.
To run the documentation live server locally, you can change into docs and make use of the following command:
npm run start
This will start the Docusaurus server at http://localhost:3000/docs/ and you will be able to easily see and test the changes you are making to the documentation source files.